Fix several project lint report warnings #498
Conversation
app/src/main/java/com/google/samples/apps/sunflower/PlantDetailFragment.kt
Outdated
Show resolved
Hide resolved
| @@ -48,6 +48,11 @@ android { | |||
| kotlinOptions { | |||
| jvmTarget = "1.8" | |||
| } | |||
| lintOptions { | |||
| disable 'GoogleAppIndexingWarning' | |||
There was a problem hiding this comment.
I don't prefer to ignore GoogleAppIndexingWarning, the purpose of sunflower project is a demo for different Android features of jetpack or androidX, the GoogleAppIndexingWarning can be one part of them.
Let the warning there is OK.
There was a problem hiding this comment.
My intension was to force warnings as errors by warningsAsErrors attribute, with that all changes has verify by CI on PR forcing to failure if was introduces new lint warnings (forcing contributors to check them). That was the only reason for why I added the disable 'GoogleAppIndexWarning'.
If you consider that isn't necessary I remove that also. Please confirm me, for make these changes on PR
app/src/main/java/com/google/samples/apps/sunflower/PlantDetailFragment.kt
Outdated
Show resolved
Hide resolved
|
Updated PR with
|
Description
Enable lint for reporting warnings as errors and detect them with CI, and solve the current project warnings
Overview
Before changes
After changes
Next steps
Redesign launch icon for avoid this warning (Error: Launcher icons should not fill every pixel of their square region; see the design guide for details [IconLauncherShape]) for the moment I just skipped it
It's a good approach also try to add another tools for static analysis in order to improve the code quality and make easy the collaboration with unified code style