This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Modify collectAsState to collectAsStateWithLifecycle #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Jaehwa-Noh
reviewed
Jul 3, 2024
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GardenPlantingListViewModel.kt
Outdated
Show resolved
Hide resolved
pachuho
force-pushed
the
consuming_flows_safely
branch
from
8ddbc3f
to
20ee26c
Compare
bentrengrove
suggested changes
Jul 3, 2024
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GardenPlantingListViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/PlantDetailViewModel.kt
Outdated
Show resolved
Hide resolved
pachuho
force-pushed
the
consuming_flows_safely
branch
from
20ee26c
to
f7f2aa9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use collectAsStateWithLifecycle to save app resources when you don't need them,
such as when they're in the background.
The following tasks have been applied.
androidx.lifecycle.lifecycle-runtime-compose