fix: update typescript-eslint packages to v8.0.0-alpha.37 (#1854)

angular-eslint · Jun 30, 2024 · afd0f37 · afd0f37
1 parent 9103be6
commit afd0f37
Show file tree

Hide file tree

Showing 15 changed files with 76 additions and 155 deletions.
diff --git a/e2e/src/__snapshots__/inline-template-fixer.test.ts.snap b/e2e/src/__snapshots__/inline-template-fixer.test.ts.snap
@@ -30,6 +30,6 @@ exports[`inline-template-fixer should generate the expected inline template fixe
   \\"karma-jasmine\\": \\"~5.1.0\\",
   \\"karma-jasmine-html-reporter\\": \\"~2.1.0\\",
   \\"typescript\\": \\"~5.4.2\\",
-  \\"typescript-eslint\\": \\"8.0.0-alpha.20\\"
+  \\"typescript-eslint\\": \\"8.0.0-alpha.37\\"
 }"
 `;
diff --git a/...src/__snapshots__/new-workspace-create-application-false-ng-add-then-project.test.ts.snap b/...src/__snapshots__/new-workspace-create-application-false-ng-add-then-project.test.ts.snap
@@ -15,7 +15,7 @@ exports[`new-workspace-create-application-false-ng-add-then-project should pass
   "karma-jasmine": "~5.1.0",
   "karma-jasmine-html-reporter": "~2.1.0",
   "typescript": "~5.X.X",
-  "typescript-eslint": "8.0.0-alpha.20"
+  "typescript-eslint": "8.0.0-alpha.37"
 }
 `;
 

diff --git a/...src/__snapshots__/new-workspace-create-application-false-project-then-ng-add.test.ts.snap b/...src/__snapshots__/new-workspace-create-application-false-project-then-ng-add.test.ts.snap
@@ -15,7 +15,7 @@ exports[`new-workspace-create-application-false-project-then-ng-add should pass
   "karma-jasmine": "~5.1.0",
   "karma-jasmine-html-reporter": "~2.1.0",
   "typescript": "~5.X.X",
-  "typescript-eslint": "8.0.0-alpha.20"
+  "typescript-eslint": "8.0.0-alpha.37"
 }
 `;
 

diff --git a/e2e/src/__snapshots__/new-workspace.test.ts.snap b/e2e/src/__snapshots__/new-workspace.test.ts.snap
@@ -16,7 +16,7 @@ exports[`new-workspace should pass linting after creating a new workspace from s
   "karma-jasmine-html-reporter": "~2.1.0",
   "ng-packagr": "^18.X.X",
   "typescript": "~5.X.X",
-  "typescript-eslint": "8.0.0-alpha.20"
+  "typescript-eslint": "8.0.0-alpha.37"
 }
 `;
 

diff --git a/package.json b/package.json
@@ -77,7 +77,7 @@
     "@types/node": "20.14.9",
     "@types/prettier": "2.7.3",
     "@types/semver": "^7.5.8",
-    "@typescript-eslint/rule-tester": "8.0.0-alpha.20",
+    "@typescript-eslint/rule-tester": "8.0.0-alpha.37",
     "commitizen": "4.3.0",
     "cz-conventional-changelog": "3.3.0",
     "env-cmd": "10.1.0",
@@ -104,7 +104,7 @@
     "tslib": "^2.4.1",
     "tsx": "^4.7.3",
     "typescript": "5.4.5",
-    "typescript-eslint": "8.0.0-alpha.20",
+    "typescript-eslint": "8.0.0-alpha.37",
     "verdaccio": "5.31.1"
   },
   "nx": {

diff --git a/packages/eslint-plugin-template/package.json b/packages/eslint-plugin-template/package.json
@@ -28,7 +28,7 @@
     "@types/aria-query": "5.0.4"
   },
   "peerDependencies": {
-    "@typescript-eslint/utils": "^7.11.0 || ^8.0.0-alpha.20",
+    "@typescript-eslint/utils": "^7.11.0 || ^8.0.0-alpha.37",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": "*"
   },

diff --git a/packages/eslint-plugin/docs/rules/contextual-lifecycle.md b/packages/eslint-plugin/docs/rules/contextual-lifecycle.md
@@ -1343,35 +1343,6 @@ class Test {
 
 #### ✅ Valid Code
 
-```ts
-@Injectable()
-class Test {
-  ngOnDestroy() { console.log('OnDestroy'); }
-}
-```
-
-<br>
-
----
-
-<br>
-
-#### Default Config
-
-```json
-{
-  "rules": {
-    "@angular-eslint/contextual-lifecycle": [
-      "error"
-    ]
-  }
-}
-```
-
-<br>
-
-#### ✅ Valid Code
-
 ```ts
 @NgModule()
 class Test {

diff --git a/packages/eslint-plugin/docs/rules/sort-lifecycle-methods.md b/packages/eslint-plugin/docs/rules/sort-lifecycle-methods.md
@@ -273,40 +273,6 @@ class Test {
 
 #### ✅ Valid Code
 
-```ts
-@Component()
-class Test {
-  ngOnChanges(): void {}
-  ngOnInit(): void {}
-  ngAfterContentInit(): void {}
-  ngAfterContentChecked(): void {}
-  ngAfterViewChecked(): void {}
-  ngOnDestroy(): void {}
-}
-```
-
-<br>
-
----
-
-<br>
-
-#### Default Config
-
-```json
-{
-  "rules": {
-    "@angular-eslint/sort-lifecycle-methods": [
-      "error"
-    ]
-  }
-}
-```
-
-<br>
-
-#### ✅ Valid Code
-
 ```ts
 @Component()
 class Test {

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -25,7 +25,7 @@
     "@angular-eslint/test-utils": "18.0.1"
   },
   "peerDependencies": {
-    "@typescript-eslint/utils": "^7.11.0 || ^8.0.0-alpha.20",
+    "@typescript-eslint/utils": "^7.11.0 || ^8.0.0-alpha.37",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": "*"
   },

diff --git a/packages/eslint-plugin/tests/rules/contextual-lifecycle/cases.ts b/packages/eslint-plugin/tests/rules/contextual-lifecycle/cases.ts
@@ -105,12 +105,6 @@ export const valid = [
       ngOnInit() { console.log('OnInit'); }
     }
     `,
-  `
-    @Injectable()
-    class Test {
-      ngOnDestroy() { console.log('OnDestroy'); }
-    }
-    `,
   `
     @NgModule()
     class Test {

diff --git a/packages/eslint-plugin/tests/rules/sort-lifecycle-methods/cases.ts b/packages/eslint-plugin/tests/rules/sort-lifecycle-methods/cases.ts
@@ -29,17 +29,6 @@ export const valid = [
       ngOnDestroy(): void {}
     }
   `,
-  `
-    @Component()
-    class Test {
-      ngOnChanges(): void {}
-      ngOnInit(): void {}
-      ngAfterContentInit(): void {}
-      ngAfterContentChecked(): void {}
-      ngAfterViewChecked(): void {}
-      ngOnDestroy(): void {}
-    }
-  `,
   `
     @Component()
     class Test {

diff --git a/packages/schematics/package.json b/packages/schematics/package.json
@@ -45,7 +45,7 @@
     "strip-json-comments": "3.1.1"
   },
   "devDependencies": {
-    "@typescript-eslint/utils": "8.0.0-alpha.20",
+    "@typescript-eslint/utils": "8.0.0-alpha.37",
     "eslint": "9.6.0"
   },
   "peerDependencies": {

diff --git a/packages/test-utils/package.json b/packages/test-utils/package.json
@@ -17,8 +17,8 @@
     "LICENSE"
   ],
   "peerDependencies": {
-    "@typescript-eslint/rule-tester": "^7.11.0 || ^8.0.0-alpha.20",
-    "@typescript-eslint/utils": "^7.11.0 || ^8.0.0-alpha.20",
+    "@typescript-eslint/rule-tester": "^7.11.0 || ^8.0.0-alpha.37",
+    "@typescript-eslint/utils": "^7.11.0 || ^8.0.0-alpha.37",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": "*"
   },

diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -17,7 +17,7 @@
     "LICENSE"
   ],
   "peerDependencies": {
-    "@typescript-eslint/utils": "^7.11.0 || ^8.0.0-alpha.20",
+    "@typescript-eslint/utils": "^7.11.0 || ^8.0.0-alpha.37",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": "*"
   },