fix(@schematics/angular): add commonjs module to universal tsconfig (#…

…15090) The universal tsconfig extends the application tsconfig which by default it's module format is ES2015. While NodeJS 12 does support this, older versions of Node don't
angular · Jul 16, 2019 · 1bc04b0 · 1bc04b0
1 parent 0c94e2b
commit 1bc04b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/schematics/angular/universal/files/root/__tsconfigFileName__.json.template b/packages/schematics/angular/universal/files/root/__tsconfigFileName__.json.template
@@ -1,7 +1,8 @@
 {
   "extends": "./<%= tsConfigExtends %>",
   "compilerOptions": {
-    "outDir": "<%= outDir %>-server"
+    "outDir": "<%= outDir %>-server",
+    "module": "commonjs"
   },
   "angularCompilerOptions": {
     "entryModule": "./<%= rootInSrc ? '' : 'src/' %><%= appDir %>/<%= stripTsExtension(rootModuleFileName) %>#<%= rootModuleClassName %>"

diff --git a/packages/schematics/angular/universal/index_spec.ts b/packages/schematics/angular/universal/index_spec.ts
@@ -90,6 +90,7 @@ describe('Universal Schematic', () => {
       extends: './tsconfig.app.json',
       compilerOptions: {
         outDir: './out-tsc/app-server',
+        module: 'commonjs',
       },
       angularCompilerOptions: {
         entryModule: './src/app/app.server.module#AppServerModule',
@@ -110,6 +111,7 @@ describe('Universal Schematic', () => {
       extends: './tsconfig.app.json',
       compilerOptions: {
         outDir: '../../out-tsc/app-server',
+        module: 'commonjs',
       },
       angularCompilerOptions: {
         entryModule: './src/app/app.server.module#AppServerModule',