Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng update should detect typings files and added it to the appropriate tsconfig file #16923

Closed
1 of 15 tasks
johnpapa opened this issue Feb 10, 2020 · 3 comments · Fixed by #16939
Closed
1 of 15 tasks

ng update should detect typings files and added it to the appropriate tsconfig file #16923

johnpapa opened this issue Feb 10, 2020 · 3 comments · Fixed by #16939

Comments

@johnpapa
Copy link
Contributor

🚀 Feature request

I have a typings.d.ts file that no longer is included in the compilation/build. I was getting errors about not being able to find my ambient types that were in that files. I noticed the tsconfig.app.json was updated to only compile the main.ts and the polyfills. Once I added the typings.d.ts explictly, it worked.

Yes, it's likely not a common scenario. But It might be good to include this scenario in the ng update process to v9.

It would be nice if the ng update process noticed if there was a typings file and added it to the config.

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc
@alan-agius4
Copy link
Collaborator

Hi @johnpapa, can you share the contents of tsconfig prior to the update?

@alan-agius4
Copy link
Collaborator

Info provided offline.

@alan-agius4 alan-agius4 removed the needs: more info Reporter must clarify the issue label Feb 12, 2020
dgp1130 pushed a commit that referenced this issue Feb 12, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants