Skip to content

Commit

Permalink
test(common): change fallback default URL in MockPlatformLocation (#4…
Browse files Browse the repository at this point in the history
…4211)

In node@16 the URL constructor fails for for a malformed URL such as http://<empty>/. Instead http://_empty_ is
used as this conveys the same information in tests but is correctly formed.

PR Close #44211
  • Loading branch information
josephperrott authored and thePunderWoman committed Nov 24, 2021
1 parent 7b0e9b0 commit 29c8fee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/common/testing/src/mock_platform_location.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export class MockPlatformLocation implements PlatformLocation {
this.baseHref = config.appBaseHref || '';

const parsedChanges =
this.parseChanges(null, config.startUrl || 'http://<empty>/', this.baseHref);
this.parseChanges(null, config.startUrl || 'http://_empty_/', this.baseHref);
this.urlChanges[0] = {...parsedChanges};
}
}
Expand Down

0 comments on commit 29c8fee

Please sign in to comment.