Skip to content

Commit

Permalink
build: remove test blocklist (#18372)
Browse files Browse the repository at this point in the history
The blocklist will be no longer used in the framework repository, so
we can remove it from the components repo too.

Related to FW-1807.
  • Loading branch information
devversion authored and mmalerba committed Feb 5, 2020
1 parent 98fac6c commit 0f7a828
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 35 deletions.
5 changes: 1 addition & 4 deletions test/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ ts_library(
name = "angular_test_init",
testonly = True,
# This file *must* end with "spec" in order for "karma_web_test_suite" to load it.
srcs = [
"angular-test-init-spec.ts",
"test-blocklist.ts",
],
srcs = ["angular-test-init-spec.ts"],
deps = [
"@npm//@angular/core",
"@npm//@angular/platform-browser-dynamic",
Expand Down
14 changes: 0 additions & 14 deletions test/angular-test-init-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting,
} from '@angular/platform-browser-dynamic/testing';
import {testBlocklist} from './test-blocklist';

/*
* Common setup / initialization for all unit tests in Angular Material and CDK.
Expand Down Expand Up @@ -55,16 +54,3 @@ function patchTestBedToDestroyFixturesAfterEveryTest(testBedInstance: TestBed) {
// https://github.com/angular/angular/blob/master/packages/core/testing/src/before_each.ts#L25
afterEach(() => testBedInstance.resetTestingModule());
}


// Filter out any tests explicitly given in the blocklist. The blocklist is empty in the
// components repository, but the file will be overwritten if the framework repository runs
// the Angular component test suites against the latest snapshots. This is helpful because
// sometimes breaking changes that break individual tests land in the framework repository.
// It should be possible to disable these tests until the component repository migrated the
// broken tests once the breaking change is released.
(jasmine.getEnv() as any).configure({
specFilter: function(spec: jasmine.Spec) {
return !testBlocklist || !testBlocklist[spec.getFullName()];
}
});
17 changes: 0 additions & 17 deletions test/test-blocklist.ts

This file was deleted.

0 comments on commit 0f7a828

Please sign in to comment.