-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: update menu modifier chord tests to workaround chromium bug
It seems that after the recent chromium update, two menu e2e tests started to fail consistently given the use of `Key.chord` with a modifier key. The problem seems to be that chromium has a bug with the revision we are using, where the chord `Key.NULL` reset key is sent as actual character to the active element instead of the key state/modifier state being reset. Related: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3999. It's low-effort to just release the keys manually here. (cherry picked from commit e99d633)
- Loading branch information
1 parent
4385603
commit 156ac3a
Showing
2 changed files
with
12 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters