Skip to content

Commit

Permalink
fix(material/chips): don't stop propagation on all click events (#19763)
Browse files Browse the repository at this point in the history
Historically we've had to stop propagation on clicks so that clicking on a chip won't move focus to the first chip once the event bubbles up to the list. This isn't necessary as of #12856 which changes how we detect clicks from inside a chip. These changes remove the call since it can prevent people's global click listeners from firing.

Fixes #19759.

(cherry picked from commit 3c5a9b7)
  • Loading branch information
crisbeto authored and mmalerba committed Jan 26, 2022
1 parent 02c8f2a commit 337634f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/material/chips/chip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,6 @@ export class MatChip
_handleClick(event: Event) {
if (this.disabled) {
event.preventDefault();
} else {
event.stopPropagation();
}
}

Expand Down

0 comments on commit 337634f

Please sign in to comment.