Skip to content

Commit

Permalink
build: remove mdc-sidenav package (#24402)
Browse files Browse the repository at this point in the history
The package was set up some time ago, but we never ended up using it. These changes remove the package so we don't have to keep mantaining its boilerplate.

(cherry picked from commit fd745d1)
  • Loading branch information
crisbeto authored and wagnermaciel committed Feb 15, 2022
1 parent db65db3 commit c902c1d
Show file tree
Hide file tree
Showing 21 changed files with 1 addition and 198 deletions.
2 changes: 0 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@
/src/material-experimental/mdc-slider/** @devversion
/src/material-experimental/mdc-tabs/** @crisbeto
/src/material-experimental/mdc-tooltip/** @crisbeto
/src/material-experimental/mdc-sidenav/** @crisbeto
/src/material-experimental/mdc-table/** @andrewseguin
/src/material-experimental/mdc-theming/** @mmalerba
/src/material-experimental/mdc-typography/** @mmalerba
Expand Down Expand Up @@ -196,7 +195,6 @@
/src/dev-app/mdc-radio/** @mmalerba
/src/dev-app/mdc-select/** @crisbeto
/src/dev-app/mdc-snack-bar/** @andrewseguin
/src/dev-app/mdc-sidenav/** @crisbeto
/src/dev-app/mdc-snack-bar/** @andrewseguin
/src/dev-app/mdc-slide-toggle/** @crisbeto
/src/dev-app/mdc-slider/** @devversion
Expand Down
1 change: 0 additions & 1 deletion .ng-dev/commit-message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export const commitMessage: CommitMessageConfig = {
'material-experimental/mdc-progress-spinner',
'material-experimental/mdc-radio',
'material-experimental/mdc-select',
'material-experimental/mdc-sidenav',
'material-experimental/mdc-slide-toggle',
'material-experimental/mdc-slider',
'material-experimental/mdc-snack-bar',
Expand Down
3 changes: 1 addition & 2 deletions scripts/check-mdc-exports-config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export const config = {
// The MDC sidenav hasn't been implemented yet.
skippedPackages: ['mdc-sidenav'],
skippedPackages: [] as string[],
// We have to export some underscored symbols so that they can be used with MDC.
// Exclude them from this check since they aren't part of the public API.
skippedSymbols: [/^_/],
Expand Down
1 change: 0 additions & 1 deletion src/dev-app/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ ng_module(
"//src/dev-app/mdc-progress-spinner",
"//src/dev-app/mdc-radio",
"//src/dev-app/mdc-select",
"//src/dev-app/mdc-sidenav",
"//src/dev-app/mdc-slide-toggle",
"//src/dev-app/mdc-slider",
"//src/dev-app/mdc-snack-bar",
Expand Down
1 change: 0 additions & 1 deletion src/dev-app/dev-app/dev-app-layout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ export class DevAppLayout {
{name: 'MDC Tabs', route: '/mdc-tabs'},
{name: 'MDC Tooltip', route: '/mdc-tooltip'},
{name: 'MDC Select', route: '/mdc-select'},
{name: 'MDC Sidenav', route: '/mdc-sidenav'},
{name: 'MDC Slide Toggle', route: '/mdc-slide-toggle'},
{name: 'MDC Slider', route: '/mdc-slider'},
{name: 'MDC Snack Bar', route: '/mdc-snack-bar'},
Expand Down
21 changes: 0 additions & 21 deletions src/dev-app/mdc-sidenav/BUILD.bazel

This file was deleted.

18 changes: 0 additions & 18 deletions src/dev-app/mdc-sidenav/mdc-sidenav-demo-module.ts

This file was deleted.

2 changes: 0 additions & 2 deletions src/dev-app/mdc-sidenav/mdc-sidenav-demo.html

This file was deleted.

1 change: 0 additions & 1 deletion src/dev-app/mdc-sidenav/mdc-sidenav-demo.scss

This file was deleted.

16 changes: 0 additions & 16 deletions src/dev-app/mdc-sidenav/mdc-sidenav-demo.ts

This file was deleted.

5 changes: 0 additions & 5 deletions src/dev-app/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,6 @@ export const DEV_APP_ROUTES: Routes = [
loadChildren: () =>
import('./mdc-select/mdc-select-demo-module').then(m => m.MdcSelectDemoModule),
},
{
path: 'mdc-sidenav',
loadChildren: () =>
import('./mdc-sidenav/mdc-sidenav-demo-module').then(m => m.MdcSidenavDemoModule),
},
{
path: 'mdc-snack-bar',
loadChildren: () =>
Expand Down
1 change: 0 additions & 1 deletion src/material-experimental/config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ entryPoints = [
"mdc-radio/testing",
"mdc-select",
"mdc-select/testing",
"mdc-sidenav",
"mdc-slide-toggle",
"mdc-slide-toggle/testing",
"mdc-slider",
Expand Down
57 changes: 0 additions & 57 deletions src/material-experimental/mdc-sidenav/BUILD.bazel

This file was deleted.

1 change: 0 additions & 1 deletion src/material-experimental/mdc-sidenav/README.md

This file was deleted.

This file was deleted.

28 changes: 0 additions & 28 deletions src/material-experimental/mdc-sidenav/_sidenav-theme.scss

This file was deleted.

9 changes: 0 additions & 9 deletions src/material-experimental/mdc-sidenav/index.ts

This file was deleted.

16 changes: 0 additions & 16 deletions src/material-experimental/mdc-sidenav/module.ts

This file was deleted.

9 changes: 0 additions & 9 deletions src/material-experimental/mdc-sidenav/public-api.ts

This file was deleted.

1 change: 0 additions & 1 deletion src/material-experimental/mdc-sidenav/sidenav.e2e.spec.ts

This file was deleted.

1 change: 0 additions & 1 deletion src/material-experimental/mdc-sidenav/sidenav.scss

This file was deleted.

0 comments on commit c902c1d

Please sign in to comment.