Skip to content

Commit

Permalink
fix(cdk/tree): remove NB: comments
Browse files Browse the repository at this point in the history
  • Loading branch information
BobobUnicorn committed May 21, 2024
1 parent c3c788a commit cea66ae
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/cdk/a11y/key-manager/tree-key-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export class TreeKeyManager<T extends TreeKeyManagerItem> implements TreeKeyMana

switch (key) {
case 'Tab':
// NB: return here, in order to allow Tab to actually tab out of the tree
// Return early here, in order to allow Tab to actually tab out of the tree
return;

case 'ArrowDown':
Expand Down
6 changes: 3 additions & 3 deletions src/cdk/tree/tree.ts
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export class CdkTree<T, K = T>
this._dataSubscription = combineLatest([
dataStream,
this._nodeType,
// NB: the data is unused below, however we add it here to essentially
// We don't use the expansion data directly, however we add it here to essentially
// trigger data rendering when expansion changes occur.
expansionModel.changed.pipe(
startWith(null),
Expand Down Expand Up @@ -955,8 +955,8 @@ export class CdkTree<T, K = T>
* nodes into a single array.
*
* If any nodes are not expanded, then their children will not be added into the array.
* NB: this will still traverse all nested children in order to build up our
* internal data models, but will not include them in the returned array.
* This will still traverse all nested children in order to build up our internal data
* models, but will not include them in the returned array.
*/
private _flattenNestedNodesWithExpansion(nodes: readonly T[], level = 0): Observable<T[]> {
const childrenAccessor = this._getChildrenAccessor();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export class VimTreeKeyManager<T extends TreeKeyManagerItem> implements TreeKeyM

switch (keyCode) {
case TAB:
// NB: return here, in order to allow Tab to actually tab out of the tree
// Return early here, in order to allow Tab to actually tab out of the tree
return;

case DOWN_ARROW:
Expand Down
2 changes: 1 addition & 1 deletion src/material/tree/tree-using-tree-control.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ describe('MatTree', () => {
(getNodes(treeElement)[1] as HTMLElement).click();
fixture.detectChanges();

// NB: only four elements are present here; children are not present
// Note: only four elements are present here; children are not present
// in DOM unless the parent node is expanded.
expect(
getNodes(treeElement)
Expand Down
2 changes: 1 addition & 1 deletion src/material/tree/tree.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ describe('MatTree', () => {
(getNodes(treeElement)[1] as HTMLElement).click();
fixture.detectChanges();

// NB: only four elements are present here; children are not present
// Note: only four elements are present here; children are not present
// in DOM unless the parent node is expanded.
expect(
getNodes(treeElement)
Expand Down

0 comments on commit cea66ae

Please sign in to comment.