Skip to content

Commit

Permalink
fix(material-experimental/mdc-button): align outline color with spec (#…
Browse files Browse the repository at this point in the history
…24249)

The spec has a grey outline for outlined buttons, but we currently set it to the theme color.
  • Loading branch information
crisbeto committed Jan 31, 2022
1 parent e8919bc commit f0f9cbe
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/material-experimental/mdc-button/_button-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
@mixin _outlined-button-variant($color) {
@include mdc-button-outlined-theme.theme((
label-text-color: $color,
outline-color: $color,
));
}

Expand Down Expand Up @@ -140,6 +139,10 @@
}

.mat-mdc-outlined-button {
@include mdc-button-outlined-theme.theme((
outline-color: rgba(mdc-theme-color.prop-value(on-surface), 0.12)
));

&.mat-unthemed {
@include _outlined-button-variant($on-surface);
}
Expand All @@ -161,9 +164,9 @@
// We need to pass both the disabled and enabled values, because the enabled
// ones apply to anchors while the disabled ones are for buttons.
label-text-color: $disabled-ink-color,
outline-color: $disabled-ink-color,
disabled-label-text-color: $disabled-ink-color,
disabled-outline-color: $disabled-ink-color,
outline-color: rgba($on-surface, 0.12),
disabled-outline-color: rgba($on-surface, 0.12),
));
}
}
Expand Down

0 comments on commit f0f9cbe

Please sign in to comment.