fix(radio): clear aria attributes from host node #16938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `aria-*` attributes are set on the host node via static bindings, we can end up with both the host and the input having the same `aria-label` which might be read out by a screen reader. These changes clear the attributes from the host. Fixes angular#16913.
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Sep 1, 2019
|
We probably do on some other components as well, but I wanted to see what @jelbourn's take is on this. |
jelbourn
approved these changes
Sep 4, 2019
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 14, 2019
Follow-up from angular#16938. Clears the `aria-*` attributes from the host node so that they're not duplicated with the underlying `input`.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 14, 2019
…ost node so that they're not duplicated with the underlying input.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 14, 2019
Follow-up from angular#16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 15, 2019
Follow-up from angular#16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.
jelbourn
pushed a commit
that referenced
this pull request
Sep 18, 2019
Follow-up from #16938. Clears the `aria-*` attributes from the host node so that they're not duplicated with the underlying `input`.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Sep 24, 2019
…lar#17085) Follow-up from angular#16938. Clears the `aria-*` attributes from the host node so that they're not duplicated with the underlying `input`. (cherry picked from commit fb390fb)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
aria-*attributes are set on the host node via static bindings, we can end up with both the host and the input having the samearia-labelwhich might be read out by a screen reader. These changes clear the attributes from the host.Fixes #16913.