-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radio): clear aria attributes from host node #16938
Conversation
If the `aria-*` attributes are set on the host node via static bindings, we can end up with both the host and the input having the same `aria-label` which might be read out by a screen reader. These changes clear the attributes from the host. Fixes angular#16913.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me. Do we need the same for slide-toggle, checkbox?
We probably do on some other components as well, but I wanted to see what @jelbourn's take is on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though it's kind of lame that we have to do this in the first place.
Follow-up from angular#16938. Clears the `aria-*` attributes from the host node so that they're not duplicated with the underlying `input`.
…ost node so that they're not duplicated with the underlying input.
Follow-up from angular#16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.
Follow-up from angular#16938. Clears the aria-* attributes from the host node so that they're not duplicated with the underlying input.
Follow-up from #16938. Clears the `aria-*` attributes from the host node so that they're not duplicated with the underlying `input`.
…lar#17085) Follow-up from angular#16938. Clears the `aria-*` attributes from the host node so that they're not duplicated with the underlying `input`. (cherry picked from commit fb390fb)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If the
aria-*
attributes are set on the host node via static bindings, we can end up with both the host and the input having the samearia-label
which might be read out by a screen reader. These changes clear the attributes from the host.Fixes #16913.