Revert "Listen for focus event on calendar cells" #24380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
approved these changes
Feb 8, 2022
zarend
added
target: patch
mmalerba
approved these changes
Feb 8, 2022
zarend
added a commit
that referenced
this pull request
Feb 8, 2022
zarend
added a commit
to zarend/components
that referenced
this pull request
Feb 9, 2022
When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Note that this is the second attempt at this. First attempt was angular#24279, which was reverted in angular#24380 due to an internal issue. Fixes angular#23483
zarend
added a commit
that referenced
this pull request
Feb 14, 2022
When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Note that this is the second attempt at this. First attempt was #24279, which was reverted in #24380 due to an internal issue. Fixes #23483
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…lendar cell (angular#24279)" (angular#24380) This reverts commit 052b97d.
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…lar#24384) When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Note that this is the second attempt at this. First attempt was angular#24279, which was reverted in angular#24380 due to an internal issue. Fixes angular#23483
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
josephperrott
deleted the
revert-24279-listen-for-focus-event-on-calendar-cells
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24279
Rolling this back as it caused an internal issue.