fix(ng-dev): yarnpkg lockfile package cannot be bundled with ESM #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESBuild bundles CommonJS packages, but some cannot be due to use of CJS-only features. The yarn lockfile is one package that needs to be kept external for it to leverage CJS features through NodeJS built-in ESM -> CJS interop.
|
Related issue: evanw/esbuild#1874 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESBuild bundles CommonJS packages, but some cannot be due to use of
CJS-only features. The yarn lockfile is one package that needs to be
kept external for it to leverage CJS features through NodeJS built-in
ESM -> CJS interop.