mysql_replication: deprecation of slave related options, adding alternatives #97

Andersson007 · 2021-02-14T08:08:34Z

SUMMARY

mysql_replication: deprecation of slave related options, adding alternatives
also announce that the word SLAVE will be replaced with REPLICA in the next major release

Relates to #78 and #98

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

mysql_replication

…natives

codecov · 2021-02-14T08:10:40Z

Codecov Report

Merging #97 (fea7c3a) into main (24a4137) will decrease coverage by 0.31%.
The diff coverage is 67.64%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   75.07%   74.75%   -0.32%     
==========================================
  Files          12       12              
  Lines        1645     1660      +15     
  Branches      423      430       +7     
==========================================
+ Hits         1235     1241       +6     
- Misses        267      272       +5     
- Partials      143      147       +4

Impacted Files	Coverage Δ
plugins/modules/mysql_replication.py	`68.61% <67.64%> (-1.66%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a4137...ce14680. Read the comment docs.

Andersson007 · 2021-02-14T08:11:27Z

@bmalynovytch @Jorge-Rodriguez @felixfontein @steveteahan

There's a big question: should we change the messages like SLAVE STARTED to REPLICA STARTED, and so on, in the next / second major release.
Of course, in this case, we'll announce it in a changelog and will add a warning that it'll be changed because it would be a breaking change.
What do you folks think?

Jorge-Rodriguez · 2021-02-14T09:40:29Z

@bmalynovytch @Jorge-Rodriguez @felixfontein @steveteahan

There's a big question: should we change the messages like SLAVE STARTED to REPLICA STARTED, and so on, in the next / second major release.
Of course, in this case, we'll announce it in a changelog and will add a warning that it'll be changed because it would be a breaking change.
What do you folks think?

I think we should go for the change and use inclusive language. Making a breaking change shouldn't make us stick with derogatory terms.

That being said, it is still a breaking change, so I think we should make great fanfare about it and begin announcing it even before we PR the changes.

Andersson007 · 2021-02-18T10:30:21Z

@bmalynovytch @Jorge-Rodriguez @felixfontein @steveteahan
ready_for_review

Andersson007 · 2021-02-21T17:49:52Z

@bmalynovytch @Jorge-Rodriguez @steveteahan ready for review

felixfontein · 2021-02-22T21:14:16Z

plugins/modules/mysql_replication.py

@@ -490,8 +506,14 @@ def main():
    # "REPLICA" must be used instead of "SLAVE"
    if uses_replica_terminology(cursor):
        replica_term = 'REPLICA'
+        if master_use_gtid == 'slave_pos':
+            module.warn('master_use_gtid "slave_pos" value is deprecated. '


Why not use module.deprecate() and disallow slave_pos in the major release?

@felixfontein 1) I wouldn't like to deprecate it in observable future 2) it's hard to predict the exact version 3) I'm waiting for anybody persuades me that it's worth to deprecate and disallow eventually :)
What do you folks think?

@felixfontein do you mean exactly slave_pos or all the expressions?

@Andersson007 I mean for all of them :)

What do you mean by "it's hard to predict the exact version"?

@felixfontein I wan't clear sorry, I mean if we say it'll be community.mysql 2.0 or 3.0 or whatever, I'm not sure it will happen. This collection is too small and breaking changes aren't introduced regularly, so it's hard to choose version and to correlate it with a term.
Let's think.. I think we could:

change releasing policy to release from special branches (now we release from main)

introduce only change of the messages I mentioned in the fragment in the next major release (2.0.0), say in 3-6 months

and then remove the options I added the aliases to in 3.0.0 in 6-12 months since now

What do you folks think?

I think the process makes sense, although I don't quite understand the impact of releasing from special branches.
Also, in a shameless wedge to push my own agenda, I think the process applies as well to the issue outlined in #101

@Jorge-Rodriguez briefly it's more complicated than just to release from main. We'll have to backport things to release branches, e.g. to stable-1, release fix versions for all supported branches, etc. Anyway, we have no option with deprecated terminology - it must be replaced, so will release from branches, no problem.

Jorge-Rodriguez · 2021-02-23T06:19:21Z

@Andersson007 @felixfontein @bmalynovytch @steveteahan
Since we're introducing breaking changes, should we piggyback on this release and drop support for the somewhat problematic REQUIRESSL privilege that's been superseeded by the tls_requires option?

Andersson007 · 2021-02-23T11:23:38Z

@Andersson007 @felixfontein @bmalynovytch @steveteahan
Since we're introducing breaking changes, should we piggyback on this release and drop support for the somewhat problematic REQUIRESSL privilege that's been superseeded by the tls_requires option?

@Jorge-Rodriguez If there's a dedicated issue, it would be really good:) So we can discuss the proposal there

Jorge-Rodriguez · 2021-02-23T13:52:09Z

@Andersson007 @felixfontein @bmalynovytch @steveteahan
Since we're introducing breaking changes, should we piggyback on this release and drop support for the somewhat problematic REQUIRESSL privilege that's been superseeded by the tls_requires option?

@Jorge-Rodriguez If there's a dedicated issue, it would be really good:) So we can discuss the proposal there

You're very right, see #101

Andersson007 · 2021-02-25T12:19:57Z

@felixfontein changed

I think we could:

change releasing policy to release from special branches (now we release from main)
introduce only change of the messages I mentioned in the fragment in the next major release (2.0.0), say in 3-6 months (done in the PR)
and then remove the options I added the aliases to in 3.0.0 in 6-12 months since now (done in the PR)

@felixfontein @Jorge-Rodriguez @bmalynovytch what do you think?

felixfontein · 2021-02-25T14:08:29Z

@Andersson007 sounds reasonable. I'd align the major version release dates with Ansible release dates if possible. (Ansible 4.0.0 is somewhat close, but 5.0.0 will probably be in a bit more than 6 months, and 6.0.0 in a bit more than a year.)

Andersson007 · 2021-02-25T14:38:09Z

@felixfontein the aligning sounds good, thanks. A year is a good term, I think. Everybody should get annoyed with the warnings and switch to the "good" options:)

Andersson007 · 2021-02-25T14:39:40Z

If nobody disagrees, I'll change the release issue next week, will do it similarly to community.general if there's no better option

Andersson007 · 2021-03-01T09:45:26Z

@Jorge-Rodriguez @felixfontein thanks for reviewing!

Andersson007 · 2021-03-01T09:47:23Z

(@Jorge-Rodriguez I don't think that anybody else will review the PR, so you, as a committer, reviewed and approved it, that's why I merged it myself)

Jorge-Rodriguez · 2021-03-07T13:46:08Z

@Andersson007 while working on something else, I've spotted instances of the deprecated language in the mysql_info module.
We should probably replace references to "master" with "primary" or similar, as well.

Andersson007 · 2021-03-08T15:01:09Z

@Jorge-Rodriguez good spot, thanks! I'll create an issue not to forget. If you like to do it, please, do. If no time / wish, let me know.

Andersson007 · 2021-03-08T15:04:05Z

#109

mysql_replication: deprecation of slave related options, adding alter…

3439a83

…natives

Andersson007 added 4 commits February 18, 2021 11:15

Add changelog fragment

3575ecc

Integration tests getslave -> getreplica

ede3b32

Change the rest of offending choices/comments

18b31a1

Add announcement about replacing SLAVE to REPLICA in messages

9d58a12

Andersson007 mentioned this pull request Feb 18, 2021

mysql_replication: change the word SLAVE to REPLICA in messages returned by the module in the next major release #98

Closed

Andersson007 changed the title ~~[WIP] mysql_replication: deprecation of slave related options, adding alternatives~~ mysql_replication: deprecation of slave related options, adding alternatives Feb 18, 2021

felixfontein reviewed Feb 22, 2021

View reviewed changes

Jorge-Rodriguez mentioned this pull request Feb 23, 2021

mysql_user: Drop support for REQUIRESSL #101

Closed

Deprecate offending values

ce14680

Andersson007 mentioned this pull request Mar 1, 2021

Release plan #31

Closed

Andersson007 merged commit e8dc2f2 into ansible-collections:main Mar 1, 2021

Andersson007 mentioned this pull request Mar 8, 2021

mysql_info: remove "slave/master" from function names, etc. #109

Closed

Andersson007 mentioned this pull request Apr 14, 2021

mysql_replication: replace Is_Slave and Is_Master returned value with Is_Replica and Is_Primary in community.mysql 3.0.0, replace master in messages with primary #145

Closed

Andersson007 mentioned this pull request Nov 29, 2021

mysql_replication: remove mode values and ret values containing master / slave #252

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mysql_replication: deprecation of slave related options, adding alternatives #97

mysql_replication: deprecation of slave related options, adding alternatives #97

Andersson007 commented Feb 14, 2021 •

edited

Loading

codecov bot commented Feb 14, 2021 •

edited

Loading

Andersson007 commented Feb 14, 2021

Jorge-Rodriguez commented Feb 14, 2021

Andersson007 commented Feb 18, 2021

Andersson007 commented Feb 21, 2021

felixfontein Feb 22, 2021

Andersson007 Feb 23, 2021

Andersson007 Feb 23, 2021

felixfontein Feb 23, 2021

Andersson007 Feb 23, 2021

Jorge-Rodriguez Feb 23, 2021

Andersson007 Feb 23, 2021

Jorge-Rodriguez commented Feb 23, 2021

Andersson007 commented Feb 23, 2021

Jorge-Rodriguez commented Feb 23, 2021

Andersson007 commented Feb 25, 2021

felixfontein commented Feb 25, 2021

Andersson007 commented Feb 25, 2021

Andersson007 commented Feb 25, 2021

Andersson007 commented Mar 1, 2021

Andersson007 commented Mar 1, 2021

Jorge-Rodriguez commented Mar 7, 2021 •

edited

Loading

Andersson007 commented Mar 8, 2021

Andersson007 commented Mar 8, 2021

mysql_replication: deprecation of slave related options, adding alternatives #97

mysql_replication: deprecation of slave related options, adding alternatives #97

Conversation

Andersson007 commented Feb 14, 2021 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

codecov bot commented Feb 14, 2021 • edited Loading

Codecov Report

Andersson007 commented Feb 14, 2021

Jorge-Rodriguez commented Feb 14, 2021

Andersson007 commented Feb 18, 2021

Andersson007 commented Feb 21, 2021

felixfontein Feb 22, 2021

Choose a reason for hiding this comment

Andersson007 Feb 23, 2021

Choose a reason for hiding this comment

Andersson007 Feb 23, 2021

Choose a reason for hiding this comment

felixfontein Feb 23, 2021

Choose a reason for hiding this comment

Andersson007 Feb 23, 2021

Choose a reason for hiding this comment

Jorge-Rodriguez Feb 23, 2021

Choose a reason for hiding this comment

Andersson007 Feb 23, 2021

Choose a reason for hiding this comment

Jorge-Rodriguez commented Feb 23, 2021

Andersson007 commented Feb 23, 2021

Jorge-Rodriguez commented Feb 23, 2021

Andersson007 commented Feb 25, 2021

felixfontein commented Feb 25, 2021

Andersson007 commented Feb 25, 2021

Andersson007 commented Feb 25, 2021

Andersson007 commented Mar 1, 2021

Andersson007 commented Mar 1, 2021

Jorge-Rodriguez commented Mar 7, 2021 • edited Loading

Andersson007 commented Mar 8, 2021

Andersson007 commented Mar 8, 2021

Andersson007 commented Feb 14, 2021 •

edited

Loading

codecov bot commented Feb 14, 2021 •

edited

Loading

Jorge-Rodriguez commented Mar 7, 2021 •

edited

Loading