-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgresql_script: new module #188
postgresql_script: new module #188
Conversation
FYI: it's not ready for testing at the moment. |
The next step is adding integration tests. I'll try to do it this-next week. |
@hunleyd @tcraxs @DanScharon @jtelcontar |
Co-authored-by: Douglas J Hunley <[email protected]>
Co-authored-by: Douglas J Hunley <[email protected]>
Co-authored-by: Douglas J Hunley <[email protected]>
Co-authored-by: Douglas J Hunley <[email protected]>
@hunleyd @tcraxs @DanScharon @jtelcontar the module and tests have been added and are ready for review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't have opportunity to pull it down and play with it, but visually it looks ok
@hunleyd thank you much for reviewing! |
SUMMARY
postgresql_script: new module - Runs SQL statements from a file.
Relates to the discussion in #180 (comment)
The rough plan is:
postgresql_query
module about deprecation of thepath_to_script
andas_single_query
options and related ret values. The warning will ask users to use thepostgresql_script
modulepostgresql_query
moduleIn this PR:
After releasing
postgresql_query
andpostgresql_script
tomodule_utils/postgres.py
and import them from there.ISSUE TYPE
COMPONENT NAME
postgresql_script