Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracker] Serious collection requirements violations that require version pinning #223

Open
24 tasks done
gotmax23 opened this issue Apr 27, 2023 · 24 comments
Open
24 tasks done

[Tracker] Serious collection requirements violations that require version pinning #223

gotmax23 opened this issue Apr 27, 2023 · 24 comments
Labels
blocker Situations which do not allow the package to be released.

Comments

@gotmax23
Copy link
Contributor

gotmax23 commented Apr 27, 2023 •
edited by felixfontein
Loading

As per https://github.com/ansible-community/ansible-build-data/blob/main/docs/policies.md#enforcement, we need to track violations of the Repository management policies. We also need to track violations when collection dependencies conflicts arise, or collections violate semantic versioning by doing breaking changes outside of major versions. When you file an issue against a collection for violating these policies, leave a comment with a link to the issue.
@felixfontein felixfontein pinned this issue Apr 27, 2023
@gotmax23 gotmax23 added the blocker Situations which do not allow the package to be released. label May 20, 2023
@gotmax23
Copy link
Contributor Author

gotmax23 commented May 21, 2023 •
edited
Loading

cyberark.pas is again violating this guideline (#235 (comment)). I filed cyberark/ansible-security-automation-collection#58.

@felixfontein felixfontein changed the title [Tracker] Collection tagging policy violations [Tracker] Serious collection requirements violations that require version pinning May 23, 2023
@felixfontein
Copy link
Contributor

felixfontein commented May 23, 2023 •
edited
Loading

dellemc.enterprise_sonic needs to be pinned to 2.0.0 in both Ansible 7 and Ansible 8 for two violations:

felixfontein added a commit to felixfontein/ansible-build-data that referenced this issue May 23, 2023
@felixfontein
Pin dellemc.enterprise_sonic to 2.0.0 in Ansible 7 (ansible-community…
7eb5bd6 
…#223).
@felixfontein felixfontein mentioned this issue May 23, 2023
Merged
@felixfontein
Copy link
Contributor

hetzner.hcloud needs to be pinned to 1.11.0 in both Ansible 7 and 8 for a semantic versioning violation: ansible-collections/hetzner.hcloud#217

@felixfontein felixfontein mentioned this issue May 23, 2023
Merged
@felixfontein
Copy link
Contributor

There has been a new release of dellemc.enterprise_sonic (2.2.0) which reverts the breaking change and declares compatibility with ansible.netcommon >5.0.0. This fixes the problems with Ansible 8 (except that the breaking change will still be mentioned in the next porting guide, even though it is no longer a breaking change - I guess we have to add an Ansible changelog entry for that), but has the downside of not allowing this release for the next Ansible 7 release since that one has ansible.netcommon 4.x.y. So we have to keep the pin for Ansible 7 (though now it has another reason), and undo it (with a changelog entry) for Ansible 8.

@felixfontein felixfontein mentioned this issue Jul 14, 2023
Merged
@felixfontein
Copy link
Contributor

The issue with hetzner.hcloud is resolved (ansible-collections/hetzner.hcloud#217, #267).

@gotmax23
Copy link
Contributor Author

inspur.ispim 2.0.1 is not tagged in https://github.com/ispim/inspur.ispim

ispim/inspur.ispim#24

@felixfontein
Copy link
Contributor

felixfontein commented Sep 11, 2023 •
edited
Loading

@felixfontein
Copy link
Contributor

cisco.meraki moved to a new repository: https://github.com/meraki/dashboard-api-ansible - I'll create PRs for ansible-build-data to adjust it.

This was referenced Sep 11, 2023
Merged
Merged
@felixfontein
Copy link
Contributor

cisco.intersight was now tagged, #289 removed the ignore for the missing tags.

@felixfontein
Copy link
Contributor

felixfontein commented Sep 25, 2023 •
edited
Loading

This was referenced Sep 26, 2023
Merged
Merged
@felixfontein
Copy link
Contributor

This was referenced Nov 6, 2023
Merged
Closed
Closed
Closed
Merged
Merged
@gotmax23
Copy link
Contributor Author

gotmax23 commented Nov 7, 2023

@gotmax23
Copy link
Contributor Author

gotmax23 commented Nov 7, 2023

Pure-Storage-Ansible/FlashArray-Collection#500

@sdodsley
Copy link

sdodsley commented Nov 7, 2023

Pure-Storage-Ansible/FlashArray-Collection#500

Resolved - poor usage of flag in the changelog. Changelogs fixed and new Collection version released

gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Nov 9, 2023
@gotmax23
Revert "8: pin purestorage.flasharray to previous release"
4c85df0 
This reverts commit 6fd2b9d.

Ref: ansible-community#223 (comment)
@gotmax23 gotmax23 mentioned this issue Nov 9, 2023
Merged
felixfontein pushed a commit that referenced this issue Nov 9, 2023
@gotmax23
Revert "8: pin purestorage.flasharray to previous release" (#321)
b76899a 
This reverts commit 6fd2b9d.

Ref: #223 (comment)
@gotmax23
Copy link
Contributor Author

gotmax23 commented Dec 1, 2023 

ERROR: found collection dependency errors!
ERROR: cisco.ise 2.6.2 version_conflict: ansible.utils-3.0.0 but needs >=2.0.0,<3.0
ERROR: cisco.dnac 6.8.1 version_conflict: ansible.utils-3.0.0 but needs >=2.0.0,<3.0
ERROR: cisco.meraki 2.16.16 version_conflict: ansible.utils-3.0.0 but needs >=2.0.0,<3.0

@gotmax23
Copy link
Contributor Author

gotmax23 commented Dec 1, 2023

@felixfontein felixfontein mentioned this issue Dec 6, 2023
Merged
@felixfontein
Copy link
Contributor

This was referenced Dec 20, 2023
Merged
Merged
Merged
Merged
@felixfontein felixfontein mentioned this issue Feb 6, 2024
Merged
@felixfontein
Copy link
Contributor

@felixfontein felixfontein mentioned this issue Feb 8, 2024
Merged
@felixfontein
Copy link
Contributor

@felixfontein
Copy link
Contributor

community.ciscosmb introduced a breaking change in 1.0.8: ansible-collections/community.ciscosmb#75

@felixfontein felixfontein mentioned this issue Apr 23, 2024
Merged
@mariolenz
Copy link
Collaborator

It looks like frr.frr fails a lot of tests. I don't care about the unit tests but the failing sanity tests are problematic. I've opened ansible-collections/frr.frr#66 to let them know.

@mariolenz
Copy link
Collaborator

mariolenz commented May 21, 2024 •
edited
Loading

community.grafana introduced a breaking change (removed feature) in 1.9.0: ansible-collections/community.grafana#367

@mariolenz mariolenz mentioned this issue May 21, 2024
Merged
@felixfontein
Copy link
Contributor

cyberark.pas 1.0.27 is not tagged: cyberark/ansible-security-automation-collection#71

@felixfontein felixfontein mentioned this issue Jun 1, 2024
Merged
@felixfontein
Copy link
Contributor

felixfontein commented Jul 4, 2024 •
edited
Loading

It's too late for version pinning since 2.6.0 of that collection has been included for some months now, but FYI: CiscoDevNet/ansible-mso#479 - I've created https://forum.ansible.com/t/7039 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker Situations which do not allow the package to be released.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mariolenz @felixfontein @gotmax23 @sdodsley