-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename included ibm.spectrum_virtualize to ibm.storage_virtualize #306
Comments
Could anyone please add |
I was just trying to implement that (see #307), when I noticed that they archived the old repository, so it will not be possible to implement step 4. |
The maintainers can unarchive the old repository (Github lets you do that), complete step 4, and then archive it again if they so desire. |
@felixfontein I've just unarchived it, thanks! Please let me know when I can archive it again |
@Andersson007 I guess once a new major release has been released from that repository (and correctly tagged). That should happen after the Ansible 9 feature freeze though. |
@felixfontein @gotmax23 thanks for your help! |
Hmm, this shouldn't have been closed yet... The next step is to create a new major version of the old collection, now that we had the Ansible 9 feature freeze, with content replaced by deprecated redirects. |
@sumitguptaibm ^ could you please release the next major version of ibm.spectrum_virtualize:
Many thanks to @felixfontein for the clarifications! |
Is this what you are looking for:
|
Are these playbooks meant to be run with In the latter case, simply delete them. In the former case: good question. There is no redirect facility for playbooks so far. You could replace their tasks with a single
The modules are deprecated for different reasons. The warning text should be set to something that makes sense for that specific module. For example, if module
The 2.0.0 collection does its deprecation only by README if I understood it correctly, which makes it basically invisible to most users. These should have bettern been properly deprecated by using meta/runtime.yml and You should definitely do the removal and replace by redirects in a 3.0.0 version. It's a breaking change, especially since you still support Ansible 2.9. |
Hi @Andersson007, |
Leaving the README as-is (https://github.com/ansible-collections/ibm.spectrum_virtualize/blob/develop/README.md) seems fine to me. |
@sumitguptaibm you should create the tag locally on the release commit and then push it to upstream. Please follow the guide https://docs.ansible.com/ansible/devel/community/collection_contributors/collection_release_without_branches.html |
@sumitguptaibm also i've just checked, you don't have the write/maintainer/or admin permissions in the repo. Please ask @Shilpi-J to give you the proper level of permissions. She's an admin in the repo. |
@Andersson007 , I got permissions for write. I have deleted the files. Would you like to check whether other changes are required, before I go ahead and put a tag of 3.0.0 with current code? |
@sumitguptaibm hello, thanks for that and sorry for the delayed reply. |
@Andersson007 , We added the redirects. |
@felixfontein do you have an opportunity to take a quick look at the collection and confirm that @sumitguptaibm can proceed with p. 3 and 4 from the comment? |
|
@sumitguptaibm there's still a lot to do here. Also this was supposed to be done for the Ansible 10 release (feature freeze was in May), so Ansible 10 now contains 2.0.0 instead of a collection having deprecated redirects. |
@felixfontein,
|
Right now 2.0.0 does not contain any redirects, but still has the full content. So far there has been no release with the content removed and replaced by deprecated redirects. Removing content requires a new major release, so you need to do a 3.0.0 release; 2.1.0 would be a semantic versioning violation.
Adressing them and releasing 3.0.0 should be sufficient. |
|
It depends on what exactly you are doing in that release. You have to conform to semantic versioning (https://semver.org/).
For the tombstone 2.0.0 is kind of OK, since the module has been removed in 2.0.0. This is not 100% OK though, since technically this is a breaking change (if folks are using the The deprecated redirects are NOT ok for a 2.5.0 release. The collection does not depend on the renamed collection, so this is a breaking change. Also the version 2.0.0 for removal of the deprecated redirects would be wrong anyway, since it must lie in the future. |
@felixfontein
|
Relates to ansible-collections/ansible-inclusion#65
The renaming process is described in README
For simplicity, assume that the next minor Ansible release is X.Y.0, and that collection foo.bar with latest release a.b.c has been renamed to baz.bam with latest release A.B.C.
The text was updated successfully, but these errors were encountered: