-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trapezoid signature change and internal checks #1354
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
+ Coverage 91.89% 91.92% +0.02%
==========================================
Files 86 86
Lines 6728 6737 +9
==========================================
+ Hits 6183 6193 +10
+ Misses 545 544 -1 ☔ View full report in Codecov by Sentry. |
@JimmyHe0527 could you check this PR out? We changed the signature of the trapezoid class. This should improve the user experience. We also implemented built-in checks to determine whether the trapezoid definition makes mathematical sense or not. Let me know your feedback. |
Description
Changing the trapezoid signature and internal checks to make it more robust and reliable.
Issue linked
Closes #1349
Checklist
feat: extrude circle to cylinder
)