Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trapezoid signature change and internal checks #1354

Merged
merged 13 commits into from
Aug 13, 2024

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Aug 12, 2024

Description

Changing the trapezoid signature and internal checks to make it more robust and reliable.

Issue linked

Closes #1349

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 12, 2024
@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests labels Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (3c5dc91) to head (836574d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
+ Coverage   91.89%   91.92%   +0.02%     
==========================================
  Files          86       86              
  Lines        6728     6737       +9     
==========================================
+ Hits         6183     6193      +10     
+ Misses        545      544       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review August 13, 2024 07:25
@RobPasMue RobPasMue requested a review from a team as a code owner August 13, 2024 07:25
@RobPasMue
Copy link
Member Author

@JimmyHe0527 could you check this PR out? We changed the signature of the trapezoid class. This should improve the user experience. We also implemented built-in checks to determine whether the trapezoid definition makes mathematical sense or not. Let me know your feedback.

@RobPasMue RobPasMue merged commit 7ffdd6b into main Aug 13, 2024
47 checks passed
@RobPasMue RobPasMue deleted the fix/trapezoid-signature branch August 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect point connectivity in sketch /trapezoid.py
3 participants