Bug/add component shared master #563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobPasMue
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Let me know once this PR is ready to review. I think it is still in progress @dastan-ansys
| master_id = new_comp.id.split("/")[-1] | ||
|
|
||
| for comp in self._master_comp.occurrences: | ||
| print(f"{comp.id} - {self.id}") |
There was a problem hiding this comment.
Avoid printing. If you want to do logging, that's fine, but do not print
| for comp in self._master_comp.occurrences: | ||
| print(f"{comp.id} - {self.id}") | ||
| if comp.id != self.id: | ||
| print("here") |
jonahrb
reviewed
Jun 20, 2023
| @@ -146,32 +146,31 @@ def __init__( | |||
| self._parent_component = parent_component | |||
| self._is_alive = True | |||
| self._shared_topology = None | |||
| self._transformed_part = transformed_part | |||
| self._master_comp = master_comp | |||
There was a problem hiding this comment.
I wouldn't shorten the name, no need to save space. I think _master_component is probably better. _master is probably acceptable too
There was a problem hiding this comment.
Yep, no need to save on characters.
|
@dastan-ansys were you still planning on adding a unit test for this bug? |
|
Also, we should consider adding documentation on how Master Components work. This will be needed. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaned up the variable names