-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adapt PyMAPDL to common plotter #2799
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great. I left some minor comments. Thank you @AlejandroFernandezLuces !!
Not sure how to force the bot to rename the changelog file, I can't do it manually, do you know how @clatapie? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, I am happy to see it within PyMAPDL!
Merging, thanks everyone again 😄 |
Overview
This PR adapts PyMAPDL to the usage of the common PyAnsys plotter. It seems that part of PyMAPDL plotter is in another repo, so this work is partially done until I figure out how to modify this other part.
As a side effect, this implementation won't allow pyvista subplotting.
To summarize, on top of improving maintainability by keeping some common plotting code in the same location, this adds the following features:
Screenshot of how the plotter looks now:
Missing:
Adapt picker to use common plotter pickerAdapt the other part of PyMAPDL