Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/node-numbering #3297

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Fix/node-numbering #3297

merged 6 commits into from
Aug 27, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 18, 2024

Description

Fix the node numbering issue generated because of attempting to remove duplicated labels.
Now we relay on the backend for that.

Issue linked

Close #3120

Checklist

@germa89 germa89 requested a review from a team as a code owner July 18, 2024 10:32
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 18, 2024 10:32
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jul 18, 2024
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (93dd176) to head (60b2e47).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3297      +/-   ##
==========================================
+ Coverage   87.13%   87.14%   +0.01%     
==========================================
  Files          55       55              
  Lines        9816     9813       -3     
==========================================
- Hits         8553     8552       -1     
+ Misses       1263     1261       -2     

@germa89
Copy link
Collaborator Author

germa89 commented Aug 20, 2024

Pinging @AlejandroFernandezLuces for review.

@germa89
Copy link
Collaborator Author

germa89 commented Aug 27, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) August 27, 2024 15:48
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 6fbaad3 into main Aug 27, 2024
63 of 64 checks passed
@germa89 germa89 deleted the fix/node-numbering branch August 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node numbering is inconsistent
2 participants