[C++] Upstream various performance, build, and best practice fixes #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mike-lischke PTAL |
jcking
force-pushed
the
cpp-string-copy
branch
from
ad16b7e
to
ea9c517
Compare
mike-lischke
suggested changes
Oct 31, 2021
jcking
force-pushed
the
cpp-string-copy
branch
from
ea9c517
to
18f2471
Compare
|
Friendly poke. |
mike-lischke
approved these changes
Nov 14, 2021
|
@parrt Another pure C++ patch ready for merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing upstream a bunch of performance, build, and best practice fixes.
Most of the performance fixes are related to incorrect/misused auto. Lots of places simply use
autowhich causes values to be copied. They have been switched toconst auto&which avoids copying-by-value. The best practice fix is switching to throwRuntimeExceptioninstead of a string literal.