Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new nuget directory for building ANTLR4 C++ runtime as 3 Nuget packages #3741

Merged
merged 4 commits into from
Jul 5, 2022

Conversation

zosrothko
Copy link
Contributor

Signed-off-by: Francis ANDRE [email protected]

Hello

This PR is adding a directory antlr4\runtime\Cpp\runtime\nuget which contains a DOS script pack.cmd that is building the c++ antlr4-runtime as 3 Nuget packages.

usage: pack vsversion release [prerelease]
as for example :

pack antlr4-runtime compiled with vs2019 for version 4.9.1 with prerelease '-rc': pack 2019 4.9.1 -rc
pack antlr4-runtime compiled with vs2019 for version 4.9.1 : pack 2019 4.9.1

Signed-off-by: Francis ANDRE <[email protected]>
@zosrothko
Copy link
Contributor Author

vs2015 & vs2017 dropped. vs2022 added.

@zosrothko
Copy link
Contributor Author

Some builds are failing by timeout...so could you check them so this PR be merged?

@KvanTTT
Copy link
Member

KvanTTT commented Jun 7, 2022

I don't think it's a problem, unfortunately we have some problems with CI machines, they are not stable. I don't think you changes affect builts.

@zosrothko
Copy link
Contributor Author

@KvanTTT Can this PR be applied please?

@KvanTTT
Copy link
Member

KvanTTT commented Jul 4, 2022

It's up to @parrt

@KvanTTT
Copy link
Member

KvanTTT commented Jul 4, 2022

Also, could you point out how and where nuget for C++ is used? I have never heard about that, I've heard only about .NET platform.

@zosrothko
Copy link
Contributor Author

zosrothko commented Jul 4, 2022

Also, could you point out how and where nuget for C++ is used? I have never heard about that, I've heard only about .NET platform.

You can get the Nuget packages ANTLR4 Runtime for C++ from here: https://int.nugettest.org/. Look for ANTLR4.Runtime.vs2019 You can install those 3 packages in a MSVC C++ projet using the 'Nuget Package Manager' and the projet will automatically get the includes, the static and/or shared library.

The PR is just adding to the source tree a pack.cmd that build those Nuget package for a new version or snapshot

@parrt
Copy link
Member

parrt commented Jul 5, 2022

I believe I manually upload to nuget from circlei builds or appveyor I think.

@parrt parrt added this to the 4.10.2 milestone Jul 5, 2022
@parrt parrt merged commit 003bd34 into antlr:dev Jul 5, 2022
@zosrothko
Copy link
Contributor Author

type:improvement comp:build target:csharp labels 14 hours ago
@parrt Sorry, but the target is cpp and not csharp!

@parrt
Copy link
Member

parrt commented Jul 6, 2022

oh wow! i didn't know nuget did anything but c#!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants