Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python LexerNoViableAltException is created with messages (#4095) #4097

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Python LexerNoViableAltException is created with messages (#4095) #4097

merged 1 commit into from
Feb 3, 2023

Conversation

Sofyan-SU
Copy link
Contributor

  • Added a message to LexerNoViableAltException (python2 & 3) : this avoids exception to be raised if the exception message is printed
  • Corrected the ErrorStrategy (Python2) :
    -> notifyErrorListeners first argument should be the message, and second the Offending Token
    -> Exception does not have getMessage method

- Added a message to LexerNoViableAltException (python2 & 3)
- Corrected the ErrorStrategy (Python2) :
notifyErrorListeners first argument should be the message, and second the Offending Token
Exception does not have getMessage method

Signed-off-by: SU Sofyan <[email protected]>
@ericvergnaud
Copy link
Contributor

Thanks, I am fine with the PR, but you haven't signed off your commit, please follow instructions in https://github.com/antlr/antlr4/blob/master/CONTRIBUTING.md

@Sofyan-SU
Copy link
Contributor Author

Sofyan-SU commented Feb 3, 2023

Commit is now signed.

@ericvergnaud
Copy link
Contributor

@parrt blessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants