Remove redundant source code from go runtime #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce must be under /v4 for modules Signed-off-by: Jim.Idle <[email protected]>
…recated Signed-off-by: Jim.Idle <[email protected]>
jimidle
force-pushed
the
feature/v4cleanup
branch
from
3857e16
to
1fc779c
Compare
|
@parrt This is the cleanup PR that will leave us with only one v4 source code for the go runtime. |
|
Thanks, Jim! |
jimidle
pushed a commit
to jimidle/antlr4
that referenced
this pull request
Mar 28, 2023
* feat: Remove the old version of the source code, as at v4.x.y the source must be under /v4 for modules Signed-off-by: Jim.Idle <[email protected]> * fix: tidy up old version of go.mod (non v4 version), which is now deprecated Signed-off-by: Jim.Idle <[email protected]> --------- Signed-off-by: Jim.Idle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the non /v4 source code from the runtime and marks the original go.mod file as redundant