Improve PredictionContext performance, fix bugs #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim.Idle <[email protected]>
Interfaces require two pointer lookups for functions and when used as Generic, they require three. This change therefore yields a small performance upgrade. This change also corrects one or two copmarisons that were using pointer comparison instead of Equals() and were bugs in the code I inherited. Signed-off-by: Jim.Idle <[email protected]>
Signed-off-by: Jim.Idle <[email protected]>
…lace Signed-off-by: Jim.Idle <[email protected]>
Signed-off-by: Jim.Idle <[email protected]>
|
@parrt - I would appreciate it if you could merge this - I am now waiting for it to complete a big bug fix for config caching. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PredictionContext in Go was an interface prior to this change. However, there was no need for an interface as the differences in the types were minor and can be catered for much faster with a simple struct and a few case statements. Interfaces are also not ideal for Generics. We can end up needing 3 pointer dereferences just to look at an int.
This PR also changes Intervals to stop using pointers. They are two simple to need that.