Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LexerATNSimulator.cs with virtual Consume #4197

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Update LexerATNSimulator.cs with virtual Consume #4197

merged 1 commit into from
Mar 21, 2023

Conversation

cxambs
Copy link
Contributor

@cxambs cxambs commented Mar 20, 2023

Allow user to subclass and consume differently. Useful for CR handling as suggested in #2519

@cxambs cxambs changed the title Update LexerATNSimulator.cs with virutal Consume Update LexerATNSimulator.cs with virtual Consume Mar 20, 2023
Allow user to subclass and consume differently. Useful for CR handling as suggested in #2519

Signed-off-by: Alberto Simões <[email protected]>
@cxambs
Copy link
Contributor Author

cxambs commented Mar 20, 2023

I understand this is a very small change, but if this gets accepted, a minor release would be very welcome.

@ericvergnaud
Copy link
Contributor

@parrt blessed

@parrt parrt added this to the 4.12.1 milestone Mar 21, 2023
@parrt parrt merged commit 8dcc652 into antlr:master Mar 21, 2023
@cxambs
Copy link
Contributor Author

cxambs commented Mar 28, 2023

Do we have a tentative date for 4.12.1?
Thanks

@parrt
Copy link
Member

parrt commented Mar 29, 2023

unfortunately not. Kinda waiting on Go updates.

@jimidle
Copy link
Collaborator

jimidle commented Mar 29, 2023 via email

@cxambs
Copy link
Contributor Author

cxambs commented Mar 29, 2023

That would be nice. Waiting for that release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants