Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev. Migration to gradle project #295

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Dev. Migration to gradle project #295

merged 1 commit into from
Oct 24, 2018

Conversation

brizjin
Copy link
Contributor

@brizjin brizjin commented Jan 29, 2017

Hello!
I did migrate project to a gradle project. And also change folders structure to gradle default folder organization. With gradle project it will be more easy to grow this project. Like testing plugin with different version of Idea just by changing Idea version in gradle.build file. Also antlr-complite can be add as a dependence to gradle build (but needs to be add to maven repos first). Also calling bild.py for generation can be done as part of gradle building process.

@parrt
Copy link
Member

parrt commented Mar 31, 2017

howdy. i don't know gradle I'm afraid though! kind of a massive change.

@brizjin
Copy link
Contributor Author

brizjin commented Nov 16, 2017

Moved branch to head of master. Now it do not change files structure. Only nessasary changes.

  • .idea/gradle.xml, gradle/wrapper/*, gradlew, gradlew.bat are all autogenerated.
  • .idea/misc.xml, .idea/modules.xml, intellij-plugin-v4.iml will autogenerate on gradle sync stage or gradle project import stage and removed only from git index
  • lib/* deleted because now it as gradle dependency in maven repo, will automatically download by gradle build task
  • META-INF/plugin.xml moved to resources/META-INF/plugin.xlm, this is restriction on build
  • bild.py removed, it replaced by generateANTLR task
  • now all project structure exists in build.gradle, where source directoris are, were all recources. Which dependencies need to be downloaded before build. Also generateANTLR task do the same as bild.py did before. It autoruns before compileJava task. Now to start project from scratch enought run runIde task and do not needs to run generateANTLR before, it will runs in first step.

@parrt
Copy link
Member

parrt commented Dec 7, 2017

Hi. I will take a look after I get 4.7.1 antlr out the door.

@gejun123456
Copy link

I hope this can be merged soon, there are lots of advantage to use gradle to build the project.
mainly help people to set up the environment quicker and could test code on different IDE version.
For the pull request I think you should add updateSinceUntilBuild false to the intellij part in build.gradle.

@parrt
Copy link
Member

parrt commented Oct 21, 2018

Ok, can you give me instructions on how to build? I've never touched gradle. @gejun123456 @brizjin

Should we do this PR or this one: 7849811

@gejun123456
Copy link

here is a tutorial about using gradle
https://www.jetbrains.org/intellij/sdk/docs/tutorials/build_system.html
reimport the plugin project with gradle
then add a gradle task configuration for the project as in the tutorial

The tutorial task runIdea need to be replaced with using runIde instead from
https://github.com/JetBrains/gradle-intellij-plugin/blob/master/README.md

We should do the PR instead of the commit

@parrt
Copy link
Member

parrt commented Oct 21, 2018

@gejun123456
Copy link

I’d love to.The pr is from https://github.com/brizjin
Here is my info
GithubId:gejun123456
FullName:Jun Ge
Email:[email protected]

@parrt
Copy link
Member

parrt commented Oct 21, 2018

oh thanks but can you edit that file with that info as part of this PR? thanks!

@gejun123456
Copy link

@brizjin can you help to edit the contributors file? thanks!

@brizjin
Copy link
Contributor Author

brizjin commented Oct 24, 2018

did update contributors file and squash all changes to one commit

@parrt parrt merged commit f16523e into antlr:master Oct 24, 2018
@parrt
Copy link
Member

parrt commented Oct 24, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants