Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复明细表自定义多级列头导出格式错误 close #2664 #2674

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Apr 22, 2024

👀 PR includes

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

  1. 修复明细表默认列头复制导出时未格式化的问题
  2. 修复明细表自定义列头复制导出格式错误的问题

🖼️ Screenshot

Before After
image image

🔗 Related issue link

close #2664

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the pr(fix) bug fix label Apr 22, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Apr 22, 2024
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Apr 22, 2024 9:29am

@lijinke666 lijinke666 changed the title fix: 修复明细表自定义列头导出格式错误 close #2664 fix: 修复明细表自定义多级列头导出格式错误 close #2664 Apr 22, 2024
Copy link
Contributor

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Apr 22, 2024
Copy link
Contributor

Size Change: -14 B (0%)

Total Size: 319 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 223 kB -14 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/index.min.js 69.3 kB
./packages/s2-react/dist/style.min.css 4 kB
./packages/s2-vue/dist/index.min.js 20.3 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

@Zhaohanqi12
Copy link

本地该如何修复?求告知

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Apr 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.04%. Comparing base (ecdc9c8) to head (f723865).
Report is 308 commits behind head on next.

Files Patch % Lines
...ckages/s2-core/src/utils/export/copy/table-copy.ts 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2674      +/-   ##
==========================================
+ Coverage   75.77%   79.04%   +3.27%     
==========================================
  Files         257      274      +17     
  Lines       11994    12415     +421     
  Branches     2464     2542      +78     
==========================================
+ Hits         9088     9813     +725     
+ Misses       1398     1063     -335     
- Partials     1508     1539      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit ae9add9 into next Apr 25, 2024
15 of 17 checks passed
@lijinke666 lijinke666 deleted the fix-2664 branch April 25, 2024 02:11
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants