Apply review suggestions

airflow/config_templates/config.yml

@@ -492,14 +492,14 @@ core:
       type: string
       example: ~
       default: "Disabled"
-    max_templated_field_size:
+    max_templated_field_length:
       description: |
         The maximum length of the rendered template field. If the value to be stored in the
         rendered template field exceeds this size, it's redacted.
       version_added: 2.9.0
       type: integer
       example: ~
-      default: "1024"
+      default: "4096"
 database:
   description: ~
   options:

airflow/serialization/helpers.py

@@ -39,19 +39,14 @@ def is_jsonable(x):
         else:
             return True
 
-    max_size = conf.getint("core", "max_templated_field_size")
+    max_length = conf.getint("core", "max_templated_field_length")
+
+    if template_field and len(str(template_field)) > max_length:
+        return (
+            f"{str(template_field)[:max_length-79]}... truncated. "
+            "You can change this behaviour in [core]max_templated_field_length"
+        )
     if not is_jsonable(template_field):
-        serialized = str(template_field)
-        if len(serialized) > max_size:
-            return (
-                "Value removed due to size. "
-                "You can change this behaviour in [core]max_templated_field_size"
-            )
-        return serialized
+        return str(template_field)
     else:
-        if template_field and len(str(template_field)) > max_size:
-            return (
-                "Value removed due to size. "
-                "You can change this behaviour in [core]max_templated_field_size"
-            )
         return template_field

tests/models/test_renderedtifields.py

@@ -27,6 +27,7 @@
 import pytest
 
 from airflow import settings
+from airflow.configuration import conf
 from airflow.models import Variable
 from airflow.models.renderedtifields import RenderedTaskInstanceFields as RTIF
 from airflow.operators.bash import BashOperator
@@ -64,12 +65,15 @@ def __ne__(self, other):
 
 class LargeStrObject:
     def __init__(self):
-        self.a = "a" * 2560
+        self.a = "a" * 5000
 
     def __str__(self):
         return self.a
 
 
+max_length = conf.getint("core", "max_templated_field_length")
+
+
 class TestRenderedTaskInstanceFields:
     """Unit tests for RenderedTaskInstanceFields."""
 
@@ -120,12 +124,12 @@ def teardown_method(self):
                 "'template_fields': ['nested1']})",
             ),
             (
-                "a" * 2560,
-                "Value removed due to size. You can change this behaviour in [core]max_templated_field_size",
+                "a" * 5000,
+                f"{('a'*5000)[:max_length-79]}... truncated. You can change this behaviour in [core]max_templated_field_length",
             ),
             (
                 LargeStrObject(),
-                "Value removed due to size. You can change this behaviour in [core]max_templated_field_size",
+                f"{str(LargeStrObject())[:max_length-79]}... truncated. You can change this behaviour in [core]max_templated_field_length",
             ),
         ],
     )