Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin responses version #22057

Closed
wants to merge 1 commit into from
Closed

pin responses version #22057

wants to merge 1 commit into from

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Mar 7, 2022

Main is broken with:

==== Providers postgres: 43 failures, 7 errors ====

tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_delete_bucket_if_not_bucket_exist: failed on setup with "TypeError: __new__() missing 1 required positional argument: 'source'"
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_delete_objects_key_does_not_exist: failed on setup with "TypeError: __new__() missing 1 required positional argument: 'source'"
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_delete_objects_one_key: failed on setup with "TypeError: __new__() missing 1 required positional argument: 'source'"
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_delete_objects_many_keys: failed on setup with "TypeError: __new__() missing 1 required positional argument: 'source'"
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_generate_presigned_url: failed on setup with "TypeError: __new__() missing 1 required positional argument: 'source'"
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_should_throw_error_if_extra_args_contains_unknown_arg: failed on setup with "TypeError: __new__() missing 1 required positional argument: 'source'"
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_should_pass_extra_args: failed on setup with "TypeError: __new__() missing 1 required positional argument: 'source'"
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_delete_bucket_if_bucket_exist: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_get_bucket_tagging_no_tags_raises_error: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_get_bucket_tagging_no_bucket_raises_error: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_put_bucket_tagging_with_valid_set: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_put_bucket_tagging_with_pair: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_put_bucket_tagging_with_pair_and_set: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_put_bucket_tagging_with_key_but_no_value_raises_error: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_put_bucket_tagging_with_value_but_no_key_raises_error: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_put_bucket_tagging_with_key_and_set_raises_error: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_put_bucket_tagging_with_value_and_set_raises_error: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_put_bucket_tagging_when_tags_exist_overwrites: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_delete_bucket_tagging: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_delete_bucket_tagging_with_no_tags: TypeError: __new__() missing 1 required positional argument: 'source'
tests/providers/amazon/aws/log/test_s3_task_handler.py::TestS3TaskHandler::test_close: TypeError: __new__() missing 1 required positional argument: 'source'

this effects tests using moto like in PR #21488

The reason for this is responses releasing new version which broke moto:
getmoto/moto#4913


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@eladkal eladkal requested a review from potiuk March 7, 2022 20:01
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

too late @eladkal :). Just rebase: https://github.com/apache/airflow/pull/22046/files

@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

Closed as duplicate of #22046

@potiuk potiuk closed this Mar 7, 2022
@potiuk potiuk closed this Mar 7, 2022
@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

I even opened our very own issue :) getsentry/responses#511

@eladkal
Copy link
Contributor Author

eladkal commented Mar 7, 2022

I even opened our very own issue :) getsentry/responses#511

Great! though we probably don't need to wait for responses to fix the issue.
We just need moto to release new version with getmoto/moto#4914

@eladkal eladkal deleted the moto branch March 7, 2022 21:03
@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

Yep. The moto maintainer reached out and commented out on our issue :)

@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

Tested moto 3.0.7.dev3 and 3.0.7.dev4 and it fixes the problem, so waiting for 3.0.7 release (they seem to iterate blasingly fast :)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants