Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add http-dubbo docs #11322

Merged
merged 16 commits into from
Jul 3, 2024
Merged

docs: add http-dubbo docs #11322

merged 16 commits into from
Jul 3, 2024
+256 −2

Conversation

ShenFeng312
Copy link
Contributor

@ShenFeng312 ShenFeng312 commented Jun 4, 2024 •
edited by kayx23
Loading

Description

Fixes #11067

Add http-dubbo docs

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@moonming moonming requested a review from kayx23 June 4, 2024 10:19
kayx23
kayx23 reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. A few comments below.

docs/en/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/http-dubbo.md Show resolved Hide resolved
docs/zh/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
docs/zh/latest/plugins/http-dubbo.md Show resolved Hide resolved
docs/en/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
docs/zh/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/http-dubbo.md Show resolved Hide resolved
docs/zh/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
docs/zh/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
ShenFeng312 and others added 9 commits June 5, 2024 09:09
@ShenFeng312 @kayx23
Update docs/en/latest/plugins/http-dubbo.md
dcc56f6 
Co-authored-by: Traky Deng <[email protected]>
@ShenFeng312 @kayx23
Update docs/zh/latest/plugins/http-dubbo.md
bf9e989 
Co-authored-by: Traky Deng <[email protected]>
@ShenFeng312 @kayx23
Update docs/zh/latest/plugins/http-dubbo.md
56ad3c0 
Co-authored-by: Traky Deng <[email protected]>
@ShenFeng312 @kayx23
Update docs/zh/latest/plugins/http-dubbo.md
b1361ed 
Co-authored-by: Traky Deng <[email protected]>
@ShenFeng312 @kayx23
Update docs/zh/latest/plugins/http-dubbo.md
68bcb47 
Co-authored-by: Traky Deng <[email protected]>
@ShenFeng312 @kayx23
Update docs/en/latest/plugins/http-dubbo.md
04915cf 
Co-authored-by: Traky Deng <[email protected]>
@ShenFeng312 @kayx23
Update docs/en/latest/plugins/http-dubbo.md
8f16142 
Co-authored-by: Traky Deng <[email protected]>
@ShenFeng312 @kayx23
Update docs/en/latest/plugins/http-dubbo.md
8df6a7f 
Co-authored-by: Traky Deng <[email protected]>
@ShenFeng312 @kayx23
Update docs/en/latest/plugins/http-dubbo.md
19dd070 
Co-authored-by: Traky Deng <[email protected]>
@kayx23 kayx23 added the wait for update wait for the author's response in this issue/PR label Jun 7, 2024
@kayx23
Copy link
Member

kayx23 commented Jun 26, 2024

@ShenFeng312 Please address the remaining review comments to move this forward, thanks.

kayx23
kayx23 reviewed Jun 28, 2024
View reviewed changes
docs/zh/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/http-dubbo.md Outdated Show resolved Hide resolved
@kayx23 kayx23 requested a review from bzp2010 June 28, 2024 03:17
@bzp2010 bzp2010 requested a review from kayx23 July 1, 2024 09:40
kayx23
kayx23 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional comments from me. However I'm not familiar with Dubbo. Other reviewers please pitch in.

@kayx23 kayx23 removed the wait for update wait for the author's response in this issue/PR label Jul 1, 2024
pottekkat
pottekkat approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English docs LGTM.

@bzp2010 bzp2010 merged commit 4dbecfd into apache:master Jul 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayx23 kayx23 kayx23 approved these changes

@pottekkat pottekkat pottekkat approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: add docs for http-dubbo plugin
5 participants
@ShenFeng312 @kayx23 @pottekkat @shreemaan-abhishek @bzp2010