AVRO-3904: [Rust] schema_compatibility module refactor #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosschroh
force-pushed
the
refactor/compatibility-check
branch
from
c143f42
to
4f1290d
Compare
|
@martin-g Please review when you have time |
martin-g
reviewed
Feb 18, 2024
marcosschroh
force-pushed
the
refactor/compatibility-check
branch
2 times, most recently
from
612e418
to
62f7493
Compare
martin-g
requested changes
Feb 20, 2024
marcosschroh
force-pushed
the
refactor/compatibility-check
branch
from
62f7493
to
eb5bf3e
Compare
martin-g
changed the title
martin-g
approved these changes
Feb 20, 2024
martin-g
pushed a commit
that referenced
this pull request
Feb 20, 2024
|
Thank you, @marcosschroh ! |
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Code refactor for
schema_compatibilitymodule.elseclause have been removedfind_mapSchemaKind::TimeMicros, SchemaKind::TimestampNanos, SchemaKind::TimestampMillis, SchemaKind::TimestampMicros, SchemaKind::LocalTimestampMillis, SchemaKind::LocalTimestampMicros, SchemaKind::LocalTimestampNanosforcheck_writer_typeVerifying this change
Code cleanup and refactor without any test coverage
Documentation