Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-2825: [csharp] Resolve: C# Logical Types throw exception on unkn… #2751
base: main
Are you sure you want to change the base?
AVRO-2825: [csharp] Resolve: C# Logical Types throw exception on unkn… #2751
Changes from 1 commit
ad61af0
e5a7ded
8909529
235d329
f7b4872
1703064
60463b5
42b0fbd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comma plz
Check warning on line 7 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check warning on line 7 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 7 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 7 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 7 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 7 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check warning on line 9 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check warning on line 9 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 9 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 9 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 9 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 9 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check warning on line 11 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check warning on line 11 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 11 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 11 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 11 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 11 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check warning on line 16 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 16 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 16 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check warning on line 21 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 21 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 21 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check warning on line 26 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 26 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 26 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps you meant nullable instead of nullible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your comment but that name pre-existed in many files in this codebase so I choose to be consistent.
Check warning on line 50 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 50 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs
Check failure on line 50 in lang/csharp/src/apache/main/Util/UnknownLogicalType.cs