Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVRO-3943] Remove obsolete folders from C++ bindings #2756

Merged
merged 3 commits into from
Feb 21, 2024
Merged

[AVRO-3943] Remove obsolete folders from C++ bindings #2756

merged 3 commits into from
Feb 21, 2024

Conversation

mkmkme
Copy link
Contributor

@mkmkme mkmkme commented Feb 20, 2024

  • Bison/Flex has been obsolete since Windows port
  • m4 folder has been obsolete likely since moving to CMake

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Feb 20, 2024
martin-g
martin-g reviewed Feb 21, 2024
View reviewed changes
lang/c++/README Show resolved Hide resolved
lang/c++/README Show resolved Hide resolved
@martin-g martin-g merged commit d0adc21 into apache:main Feb 21, 2024
4 checks passed
martin-g pushed a commit that referenced this pull request Feb 21, 2024
@mkmkme @martin-g
[AVRO-3943] Remove obsolete folders from C++ bindings (#2756)
a87063a 
* AVRO-3943: Remove obsolete Bison/Flex files

* AVRO-3943: Remove obsolete m4 files

* AVRO-3943: Remove mentions of bison and flex from README

(cherry picked from commit d0adc21)
@martin-g
Copy link
Member

Thank you, @mkmkme !

@mkmkme mkmkme deleted the mkmkme/obsolete-files branch February 21, 2024 13:59
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
@mkmkme
[AVRO-3943] Remove obsolete folders from C++ bindings (apache#2756)
6e94d85 
* AVRO-3943: Remove obsolete Bison/Flex files

* AVRO-3943: Remove obsolete m4 files

* AVRO-3943: Remove mentions of bison and flex from README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g left review comments

Assignees
No one assigned
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkmkme @martin-g