[AVRO-3944] small CMake fixes #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version triggers a warning during configuration phase:
CMake Deprecation Warning at CMakeLists.txt:19 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
CMake 3.5.0 has been released in 2016, so it's safe to assume it's
available everywhere, which correlates with the information from
pkgs.org [1].
[1]: https://pkgs.org/search/?q=cmake&on=name
The if-statement was always true since minimum cmake version was set to 3.1. Instead, replace this condition with `if (APPLE)` since this policy makes sense only on macOS.
martin-g
approved these changes
Feb 21, 2024
martin-g
pushed a commit
that referenced
this pull request
Feb 21, 2024
* Bump cmake_minimum_required to 3.5.
Current version triggers a warning during configuration phase:
CMake Deprecation Warning at CMakeLists.txt:19 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
CMake 3.5.0 has been released in 2016, so it's safe to assume it's
available everywhere, which correlates with the information from
pkgs.org [1].
[1]: https://pkgs.org/search/?q=cmake&on=name
* CMake: fix the setting CMP0042 policy
The if-statement was always true since minimum cmake version was set to
3.1.
Instead, replace this condition with `if (APPLE)` since this policy
makes sense only on macOS.
(cherry picked from commit 3aec6f4)
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
* Bump cmake_minimum_required to 3.5.
Current version triggers a warning during configuration phase:
CMake Deprecation Warning at CMakeLists.txt:19 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
CMake 3.5.0 has been released in 2016, so it's safe to assume it's
available everywhere, which correlates with the information from
pkgs.org [1].
[1]: https://pkgs.org/search/?q=cmake&on=name
* CMake: fix the setting CMP0042 policy
The if-statement was always true since minimum cmake version was set to
3.1.
Instead, replace this condition with `if (APPLE)` since this policy
makes sense only on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation