[C++] properly format some of the tests #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use raw string literals and format JSON to improve readability.
martin-g
approved these changes
Feb 23, 2024
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
Use raw string literals and format JSON to improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use raw string literals and format JSON to improve readability.
What is the purpose of the change
I was doing some stuff related to AVRO-3945 and realised some of it deserves a new test case. I wanted to understand how do the tests from
CodecTests.ccwork and found it quite difficult due to the formatting.In some near future I hope to switch to C++20 to enable designated initializers. But for that I'll have to check the version of the compilers in the CI. For now this should do.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation