AVRO-3994 [C++] Do not escape solidus in JSON output #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON standard permits a solidus (/) to be escaped in strings, but does not require that it be escaped. Most JSON serializers used by other packages/languages do not escape solidus characters, so for consistency it would be nice if Avro also did not perform this useless escape.
mkmkme
approved these changes
Jun 7, 2024
|
I just noticed there is no Jira ticket for this. We'll need one for the changelog |
|
I created AVRO-3994 to track this change |
Gerrit0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The JSON standard permits a solidus (
/) to be escaped in strings, but does not require that it be escaped. Most JSON serializers used by other packages/languages do not escape solidus characters, so for consistency it would be nice if Avro also did not perform this useless escape.Verifying this change
This change is already covered by existing json tests, I've added additional test cases to ensure full coverage.
Documentation