Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3995 [C++] Require C++17 to compile Avro #2949

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

Gerrit0
Copy link
Contributor

@Gerrit0 Gerrit0 commented Jun 10, 2024

What is the purpose of the change

AVRO-3995 Update the CMake configuration to provide a useful error message when attempting to compile with an unsupported C++ standard version, and remove code which was #ifdef'd to be used only with C++ targets less than C++17.

As discussed in #2431, Avro has effectively required C++17 for nearly a year now, but it wasn't obvious to consumers.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? No
  • If yes, how is the feature documented? N/A

@Gerrit0 Gerrit0 changed the title AVRO-3995 [C++] Requires C++17 to compile Avro AVRO-3995 [C++] Require C++17 to compile Avro Jun 10, 2024
@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Jun 10, 2024
@Fokko
Copy link
Contributor

Fokko commented Jun 12, 2024

@Gerrit0 Can you rebase now #2931 is in?

@Gerrit0
Copy link
Contributor Author

Gerrit0 commented Jun 13, 2024

@Fokko done!

@martin-g martin-g merged commit 1a348b2 into apache:main Jun 13, 2024
4 checks passed
@martin-g
Copy link
Member

Thank you, @Gerrit0 !

@Gerrit0 Gerrit0 deleted the cpp-17 branch June 13, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants