AVRO-3998: Switch Perl library from JSON::XS to JSON::MaybeXS #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON::MaybeXS library serves as a compatibility layer to allow users to select the JSON backend that matches their stack, rather than forcing them to install a specific one, while still benefiting from the performance boost of XS libraries if they are available.
martin-g
approved these changes
Jun 12, 2024
|
@martin-g I've sent in an account request 🙇 |
|
Approved it! |
jjatria
changed the title
|
@martin-g: There's a ticket now: https://issues.apache.org/jira/browse/AVRO-3998 |
Fokko
changed the title
Fokko
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The JSON::MaybeXS library serves as a compatibility layer to allow users to select the JSON backend that matches their stack, rather than forcing them to install a specific one, while still benefiting from the performance boost of XS libraries if they are available.
Ticket: https://issues.apache.org/jira/browse/AVRO-3998
Verifying this change
This change changes one dependency for a different one with the same interface that serves as an intermediate layer. Existing tests that exercise JSON encoding / decoding verify that this is the case.
In particular, these tests exercise the modified code:
t/01_schema.tt/05_protocol.tThe only part of the code that changed that is not covered by tests is the
avro-to-jsonutility underbin.Documentation