AVRO-3999 - Avoid warnings in Perl test suite #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the schema did not match in a call to Avro::BinaryDecoder::decode, a Avro::Schema::Error::Mismatch error was thrown without a body. This was generating a warning when trying to stringify an undefined value, and resulted in the empty string being used as the error message, which was not veryb informative. This change adds a message which should solve both issues.
This silences a loud warning in xt/schema.t
jjatria
changed the title
martin-g
approved these changes
Jun 12, 2024
|
Thank you, @jjatria ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-3999
What is the purpose of the change
The test suite generated several warnings which could easily be avoided. The changes in this PR make sure the test suite can complete without triggering these scenarios.
Specifically, this PR includes the following changes:
nextinxt/schema.tTicket: https://issues.apache.org/jira/browse/AVRO-3999
Verifying this change
The change only touches the test suite, and does not change any of the tested behaviours, only the behaviour of the tests.
Documentation