AVRO-1514: Clean up Perl dependencies #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minimises the chance of duplicates sneaking by.
JSON::MaybeXS comes installed in the Perl container we get from the perl setup Github action, but it's probably a good idea to be explicit about it.
jjatria
force-pushed
the
avro-1514-perl-dependencies
branch
from
1ab1678
to
2cef927
Compare
martin-g
approved these changes
Jun 24, 2024
|
Thank you, @jjatria ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Many of the changes in this pull request were made back in 2014 by John Karp for https://issues.apache.org/jira/browse/AVRO-1514, motivated by the fact that we were no longer constrained by targetting 5.8 (since we are currently targetting 5.10).
The main motivation here was to remove some dependencies that were no longer needed (like IO::String), add some dependencies that were not properly reported (Module::Install and friends as configure dependencies, Test::Pod as a test dependency, etc), and generally clean up some of the dependencies particularly in the Github actions, which were installing many Perl dependencies twice (once with apt, once with cpanm).
Verifying this change
This change only affects the way dependencies are reported and installed, and is already covered by existing tests, such as
.github/workflows/test-lang-perl.ymland.github/workflows/test-lang-perl-ARM.yml.No dependencies that were reported are being removed, only new ones that were missing, so this should be a safe change.
Documentation