AVRO-1523 [Perl] Fix valid range for int and long #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for valid int and long values was using the absolute value of the input, but in in two's complement arithmetic types the minimum and maximum values have different absolute values, which resulted in the minimum values for both types being rejected (because their absolute values are greater than those of the corresponding maxima). This change fixes this and expands the binary encoder tests to check the ends of the accepted ranges.
martin-g
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for valid int and long values was using the absolute value of the input, but in in two's complement arithmetic types the minimum and maximum values have different absolute values, which resulted in the minimum values for both types being rejected (because their absolute values are greater than those of the corresponding maxima).
This change fixes this and expands the binary encoder tests to check the ends of the accepted ranges.
The change in this PR is based on an original submission by John Karp submitted in 2014 to https://issues.apache.org/jira/browse/AVRO-1523.
Verifying this change
This change extended
t/02_bin_encode.tto add tests for these scenarios, for values just in and just out of the accepted ranges, on both the lower and upper bounds.Documentation