AVRO-4010: [Rust] Avoid re-resolving schema on every read() #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martin-g Can you please review this performance improvement? |
|
Please don't force push! It is hard to see what change you did to fix the broken build since the last time. |
martin-g
approved these changes
Jul 3, 2024
martin-g
pushed a commit
that referenced
this pull request
Jul 3, 2024
Co-authored-by: Michael Spector <[email protected]> (cherry picked from commit f3b6ee2)
|
Thank you, @spektom ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization that allows to eliminate schema re-resolving on every read() by caching resolved schema in the reader instance.
The change is not breaking the API.
The documentation changes are not needed.
This improves the performance by 25% for my use case.