AVRO-4016: [Java] Use SecureRandom for file sync markers #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Jul 10, 2024
opwvhk
added a commit
to opwvhk/avro
that referenced
this pull request
Jul 11, 2024
(cherry-picked from 25d8684)
opwvhk
added a commit
to opwvhk/avro
that referenced
this pull request
Jul 11, 2024
(cherry-picked from 25d8684)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
AVRO-4016: Use SecureRandom for file sync markers
Currently, sync markers are generated using an MD5 hash on a random UUID and a timestamp, but the spec simply requires a "16-byte, randomly-generated sync marker".
This change creates just that.
Verifying this change
To verify, all existing tests must continue working.
Documentation
yes/ no)docs / JavaDocs / not documented)