-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for parameter cidrlist
added to the UI
#6869
Support for parameter cidrlist
added to the UI
#6869
Conversation
Found UI changes, kicking a new UI QA build |
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report
@@ Coverage Diff @@
## main #6869 +/- ##
=========================================
Coverage 10.84% 10.85%
- Complexity 7104 7106 +2
=========================================
Files 2485 2485
Lines 245417 245417
Branches 38326 38326
=========================================
+ Hits 26627 26631 +4
+ Misses 215521 215515 -6
- Partials 3269 3271 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
@JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✖️ |
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✖️ |
@JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM
Merging this one based on the approvals and build result. |
@GutoVeronezi @JoaoJandre @stephankruggg |
@weizhouapache, yes, we have a process; however, as you may know by personal experience, sometimes some use cases are missed. Thanks for fixing the regression, we will pay more attention in next PRs. |
@GutoVeronezi I have a suggestion: If any of you have tested a PR, can you comment the PR that you have tested it, for example "manually tested ok" ? It would be much better if test steps and results are added as well. |
Description
PR #6460 reimplemented the
cidrlist
in APIcreateLoadBalancerRule
; However, this parameter was not implemented in the UI. This PRs intends to implement thecidrlist
field in the create load balancer rule form.This PR also fixes the
BulkActionView.vue
, which currently throws an exception when used.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
This was tested in a local lab, by running
npm run serve
and creating/deleting load balancer rules withcidrlists
. The BulkActionView was also tested: before this change it was throwing an exception and was not opening the form. After the changes, it worked fine.