Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MATH-1539] use System.arraycopy instead of loop for better performance. #143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

XenoAmess
Copy link
Contributor

use System.arraycopy instead of loop.

@XenoAmess XenoAmess closed this Jun 5, 2020
@XenoAmess XenoAmess reopened this Jun 5, 2020
@coveralls
Copy link

coveralls commented Jun 5, 2020

Coverage Status

Coverage increased (+0.007%) to 90.563% when pulling a6d8853 on XenoAmess:use_System.arraycopy into ba8a267 on apache:master.

@XenoAmess XenoAmess closed this Jun 5, 2020
@XenoAmess XenoAmess reopened this Jun 6, 2020
@XenoAmess XenoAmess force-pushed the use_System.arraycopy branch 2 times, most recently from 10d0186 to 50fb61d Compare June 6, 2020 12:13
@XenoAmess XenoAmess changed the title use System.arraycopy use System.arraycopy instead of loop for better performance. Jun 6, 2020
@XenoAmess XenoAmess changed the title use System.arraycopy instead of loop for better performance. [MATH-1539] use System.arraycopy instead of loop for better performance. Jun 6, 2020
@XenoAmess
Copy link
Contributor Author

XenoAmess commented Jun 6, 2020

related informations about this change: https://stackoverflow.com/questions/8526907/is-javas-system-arraycopy-efficient-for-small-arrays

do I still need a jmh performance benchmark for this pr?
means to create a test for showing whether System.arrayCopy faster than original copy in loop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants