-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MATH-1538] refine some codes dealing with filling an array with its first and second elements. #144
base: master
Are you sure you want to change the base?
Conversation
benchmark result:
|
benchmark result json:
|
the original codes works like |
@@ -1497,11 +1497,11 @@ public void cosh(final double[] operand, final int operandOffset, | |||
|
|||
// create the function value and derivatives | |||
double[] function = new double[1 + order]; | |||
function[0] = FastMath.cosh(operand[operandOffset]); | |||
final double function0 = function[0] = FastMath.cosh(operand[operandOffset]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final
is useless, and not the code style for these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final is useless
Yep, if you think it that way.
and not the code style for these files
There is final for local variable for class FieldDenseMatrix
, TricubicInterpolator
, UnivariatePeriodicInterpolator
, FieldDenseMatrix
, SobolSequenceGenerator
, GeometryExample
, and several test classes.
So I think the final
I used is not outside of "the code style for these files", thus no need to change.
Or if I mis-understand something, please tell me.
Thanks.
benchmark code: